Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change opencensus tracing to opentelemetry tracing #1767

Merged
merged 1 commit into from
Sep 2, 2022
Merged

change opencensus tracing to opentelemetry tracing #1767

merged 1 commit into from
Sep 2, 2022

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Aug 16, 2022

Merge branch 'master' into update/deps/version

Signed-off-by: kpango kpango@vdaas.org

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango marked this pull request as ready for review August 16, 2022 02:14
@codecov
Copy link

codecov bot commented Aug 16, 2022 •
edited
Loading

Codecov Report

Base: 50.23% // Head: 30.24% // Decreases project coverage by -19.99% ⚠️

Coverage data is based on head (90723c7) compared to base (97eed29).
Patch coverage: 3.66% of modified lines in pull request are covered.

❗ Current head 90723c7 differs from pull request most recent head 576ce13. Consider uploading reports for the commit 576ce13 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1767       +/-   ##
===========================================
- Coverage   50.23%   30.24%   -20.00%     
===========================================
  Files         231      372      +141     
  Lines       13464    33705    +20241     
===========================================
+ Hits         6764    10194     +3430     
- Misses       6499    23118    +16619     
- Partials      201      393      +192
Impacted Files Coverage Δ
cmd/tools/cli/loadtest/main.go 0.00% <ø> (ø)
hack/benchmark/assets/x1b/loader.go 0.00% <ø> (ø)
hack/benchmark/internal/assets/dataset.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/insert.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/operation.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/option.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/remove.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/search.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/util.go 0.00% <ø> (ø)
hack/gorules/rules.go 0.00% <ø> (ø)
... and 228 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hlts2
hlts2 previously approved these changes Aug 16, 2022
View reviewed changes
vankichi
vankichi previously approved these changes Aug 16, 2022
View reviewed changes
@kpango kpango dismissed stale reviews from vankichi and hlts2 via ed21bcc August 16, 2022 08:57
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 16, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 576ce13
Status: ✅  Deploy successful!
Preview URL: https://b43badfb.vald.pages.dev
Branch Preview URL: https://update-deps-version.vald.pages.dev

View logs

@kpango kpango force-pushed the update/deps/version branch 2 times, most recently from 49fa400 to 3aa3940 Compare August 16, 2022 11:09
@kpango kpango force-pushed the update/deps/version branch 2 times, most recently from 336f262 to 8e40037 Compare August 18, 2022 03:41
@kpango kpango force-pushed the update/deps/version branch 3 times, most recently from f93beea to 77a860e Compare August 25, 2022 07:09
@kpango kpango force-pushed the update/deps/version branch 2 times, most recently from 82108f3 to 30810e1 Compare August 30, 2022 03:00
github-actions[bot]
github-actions bot reviewed Aug 30, 2022
View reviewed changes
internal/net/grpc/proto/proto_test.go Outdated Show resolved Hide resolved
internal/net/grpc/proto/proto_test.go Outdated Show resolved Hide resolved
pkg/gateway/filter/handler/grpc/handler.go Show resolved Hide resolved
pkg/gateway/filter/handler/grpc/handler.go Show resolved Hide resolved
internal/circuitbreaker/options_test.go Show resolved Hide resolved
internal/observability/trace/trace.go Show resolved Hide resolved
@kpango kpango force-pushed the update/deps/version branch 3 times, most recently from 88ec538 to 6adb5c1 Compare September 2, 2022 08:29
@kpango kpango changed the title update depenencies version and small refactor change opencensus tracing to opentelemetry tracing Sep 2, 2022
github-actions[bot]
github-actions bot reviewed Sep 2, 2022
View reviewed changes
apis/docs/v1/docs.md Show resolved Hide resolved
apis/docs/v1/docs.md

<a name="vald-v1-Insert"></a>

### Insert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Insert
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC

@kpango
change opencensus tracing to opentelemetry tracing
576ce13 
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango merged commit 8ec79af into main Sep 2, 2022
@kpango kpango deleted the update/deps/version branch September 2, 2022 09:14
github-actions[bot]
github-actions bot reviewed Sep 2, 2022
View reviewed changes
internal/circuitbreaker/options_test.go
type args struct {
tp Tripper
}
type want struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
type want is unused (unused)

@kevindiu kevindiu mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@hlts2 hlts2 hlts2 left review comments

@vankichi vankichi vankichi left review comments

Assignees
No one assigned
Labels
area/agent/core area/agent/sidecar area/discoverer area/gateway/filter area/gateway/lb area/helm area/internal area/makefile area/manager/index area/tools/cli/loadtest priority/low size/XXXL team/set SET team team/sre SRE team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpango @vdaas-ci @vankichi @hlts2